From 8b615e7e35e56e3197ff295315af488e3c0b79cd Mon Sep 17 00:00:00 2001
From: Jonathan Golder <jonathan@golderweb.de>
Date: Fri, 26 May 2017 18:35:15 +0200
Subject: [PATCH] Make short circuit "not outdated" less complicated

---
 letsencrypt-renew.sh | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/letsencrypt-renew.sh b/letsencrypt-renew.sh
index fc385ee..7873b36 100755
--- a/letsencrypt-renew.sh
+++ b/letsencrypt-renew.sh
@@ -49,13 +49,12 @@ for inifile in "${LECONFIGDIR}"/cli-*.ini; do
 	sleep $(expr $RANDOM % 600)
 
 	# Check validity of cert for domain
-	openssl x509 -checkend $(( 21 * 86400 )) -in "${LECONFIGDIR}/live/${domain}/cert.pem" > /dev/null
+	openssl x509 -checkend $(( 21 * 86400 )) -in "${LECONFIGDIR}/live/${domain}/cert.pem" > /dev/null && continue
 
-	if [ $? != 0 ]; then
-		# run let's encrypt
-		letsencrypt certonly -c "${inifile}"
-		# import certificate
-		uberspace-add-certificate -k "${LECONFIGDIR}/live/${domain}/privkey.pem" -c "${LECONFIGDIR}/live/${domain}/cert.pem"
-	fi
+	# run let's encrypt
+	letsencrypt certonly -c "${inifile}"
+
+	# import certificate
+	uberspace-add-certificate -k "${LECONFIGDIR}/live/${domain}/privkey.pem" -c "${LECONFIGDIR}/live/${domain}/cert.pem"
 
 done